Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bundling a global allocator #70

Closed
TheButlah opened this issue Oct 7, 2022 · 3 comments
Closed

Stop bundling a global allocator #70

TheButlah opened this issue Oct 7, 2022 · 3 comments

Comments

@TheButlah
Copy link
Contributor

Looks like esp-wifi includes a global allocator. It would be better to let the user choose their own global allocator.

I'll submit a PR to do this.

@fenduru
Copy link

fenduru commented Oct 9, 2022

This also prevents me from using esp-wifi in a project freshly created with https://github.com/esp-rs/esp-idf-template as both the std and no-std options there bring in an allocator

@MabezDev
Copy link
Member

This also prevents me from using esp-wifi in a project freshly created with https://github.com/esp-rs/esp-idf-template as both the std and no-std options there bring in an allocator

@fenduru if you are using an esp-idf based project, you do not need esp-wifi. The esp-idf-* packages already cover WiFi usage.

@fenduru
Copy link

fenduru commented Oct 10, 2022

@MabezDev they don't cover BLE

EDIT: On second thought I don't even need the IDF for my use case so I'm going to switch to the esp-template instead, but it does still seem like global allocator initialization is something that the final binary should be doing rather than a library (since there can only be one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants