Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running mbrola on Windows #76

Open
rhdunn opened this issue Jan 15, 2016 · 1 comment
Open

Fix running mbrola on Windows #76

rhdunn opened this issue Jan 15, 2016 · 1 comment
Milestone

Comments

@rhdunn
Copy link
Member

rhdunn commented Jan 15, 2016

This involves:

  1. Factoring out the path resolution to a helper method (environment variable, registry key+value, user path, default path).
  2. Using (1) to locate the mbrola binary (on POSIX) or DLL (on Windows).
  3. Use (1) to locate the mbrola voices.

This should make it easier to use the installed mbrola binaries on Windows.

@rhdunn rhdunn added this to the 1.49.0 milestone Jan 15, 2016
@rhdunn rhdunn changed the title Make it easier to specify where mbrola is installed on Windows Fix running mbrola on Windows May 28, 2017
@rhdunn
Copy link
Member Author

rhdunn commented May 28, 2017

  • Bulid the MBROLA voice files from the Windows solution file.
  • Test using an MBROLA voice, fixing any issues.
  • Update the documentation on installing and configuring mbrola (move that part to the readme file).

NOTE: This only works with a 32-bit version of espeak-ng. That loads the mbrola DLL correctly, so the loading logic does not need to change on that setup. Supporting mbrola on 64-bit espeak-ng is more complex, as it would require creating a 32-bit COM DLL to call the mbrola APIs from, then using the mbrowrap code to call the COM DLL on 64-bit Windows. That is out of the scope for this issue -- people wanting mbrola voices on Windows should be directed to the 32-bit version of espeak-ng.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant