Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorthand property references are broken #183

Closed
jamiebuilds opened this issue Jul 24, 2015 · 5 comments
Closed

Shorthand property references are broken #183

jamiebuilds opened this issue Jul 24, 2015 · 5 comments
Labels

Comments

@jamiebuilds
Copy link

import foo from 'foo';

export default {
  foo
}

foo might be named like _foo but the object property shorthand is left as is.

Related Issue: marionettejs/backbone-metal#28
Related Commit: marionettejs/backbone-metal@4cfec96

@szwacz
Copy link

szwacz commented Jul 24, 2015

What you are talking about here is different ES6 feature which just happens to be used with export in your case. Esperanto is responsible only for transpiling modules.

@jamiebuilds
Copy link
Author

What you are talking about here is different ES6 feature which just happens to be used with export

Yes I'm well aware of that.

Esperanto is responsible only for transpiling modules.

It's also responsible for transpiling the references it creates, so this falls well within the responsibility of esperanto. I'm not asking for it to transpile all shorthand properties, just the ones it needs to in order to actually work.

@Rich-Harris
Copy link
Contributor

Yep, this definitely qualifies as a bug. Lord knows when I'll have time to address it properly... PRs gladly accepted in the meantime 😊

@Rich-Harris
Copy link
Contributor

This will now be fixed in 0.8.0 (see #184), but my recommendation would be to use Rollup directly instead.

@jamiebuilds
Copy link
Author

Clearing out old issues, closing for inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants