POWR316D TM1621 kwh reporting

[rubydesign]

The problem

The display reports wh when it says kWh

Which version of ESPHome has the issue?

2022.12.3

What type of installation are you using?

Home Assistant Add-on

Which version of Home Assistant has the issue?

latest

What platform are you using?

ESP32

Board

nodemcu-32s

Component causing the issue

TM1621

Example YAML snippet

Yaml configuration from here https://www.esphome-devices.com/devices/Sonoff-POW-Elite-16a

specifically display yaml

display:
  platform: tm1621
  id: tm1621_display
  cs_pin: GPIO25
  data_pin: GPIO14
  read_pin: GPIO26
  write_pin: GPIO27
  lambda: |-
    if (id(page).state) {
      it.display_voltage(true);
      it.display_kwh(false);
      it.printf(0, "%.1f", id(v_sensor).state);
      it.printf(1, "%.1f", id(a_sensor).state);
    } else {  
      it.display_voltage(false);
      it.display_kwh(true);
      it.printf(0, "%.1f", id(wh_sensor).state);
      it.printf(1, "%.1f", id(w_sensor).state);
    }

Anything in the logs that might be useful for us?

It seems to me that the choice of wh is good for accuracy of reporting.
I am just a little worried that in wh the display will stop after only 10 kWh which is not a lot.
That is how i am reading this 

https://github.com/esphome/esphome/blob/dev/esphome/components/tm1621/tm1621.cpp#L112

but maybe i am wrong?
Maybe it is just a documentation issue and the printf should divide by 1000 ?

Additional information

Generally i am very happy to see that support for this is in, thanks!
And that esphome works so well, we are very grateful.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[splitbrain]

Yeah I found that weird as well, but I think its a display problem only. The internal sensor counts Wh but the display shows KWh in the default firmware. I simply changed the line to this to have it display KWh with esphome as well:

it.printf(0, "%.1f", id(wh_sensor).state / 1000);