Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAX7219digit] flip_x commit breaks reversed display #4432

Closed
voed opened this issue Apr 20, 2023 · 6 comments · Fixed by esphome/esphome#4727
Closed

[MAX7219digit] flip_x commit breaks reversed display #4432

voed opened this issue Apr 20, 2023 · 6 comments · Fixed by esphome/esphome#4727

Comments

@voed
Copy link

voed commented Apr 20, 2023

The problem

The last commit from @rafal83 breaks rotated and reversed displays. My clock is installed upside down so i used to rotate & flip it and it worked fine:

    rotate_chip: 180
    reverse_enable: true

But with that commit the display is completely broken(see details)

Which version of ESPHome has the issue?

2023.04

What type of installation are you using?

Home Assistant Add-on

Which version of Home Assistant has the issue?

2023.4.3

What platform are you using?

ESP32

Board

No response

Component causing the issue

MAX7219digit

Example YAML snippet

display:
  - platform: max7219digit
    cs_pin: GPIO25
    num_chips: 4
    intensity: 0
    rotate_chip: 180
    reverse_enable: false
    flip_x: false
    lambda: |-
      it.print(0, 5, id(digit_font), TextAlign::CENTER_LEFT, "1234567890");

image

==========================================================================

reverse_enable: false
flip_x: true

image

==========================================================================

reverse_enable: true
flip_x: true

With reverse enable the text is even duplicated from both directions

image

==========================================================================

reverse_enable: true
flip_x: false

image

Anything in the logs that might be useful for us?

No response

Additional information

No response

@voed voed changed the title flip_x commit breaks reversed display [MAX7219digit] flip_x commit breaks reversed display Apr 20, 2023
@martin131
Copy link

same problem

@voed
Copy link
Author

voed commented Apr 20, 2023

If anyone interested in easy and quick fix, i have created a reverse commit. Just add to your config:

external_components:
  - source: github://voed/esphome@dev
    components: [ max7219digit ]

@sheminasalam
Copy link

same issue

@ajakubek80
Copy link

same problem

1 similar comment
@tomber71
Copy link

same problem

@jan-gerard
Copy link

Similar issue. My display is not rotated, but I need to use reverse_enable: true, and now the individual displays are flipped in X. The flip_x option does not have any effect. I tested all four boolean combinations of reverse_enable and flip-x, and only reverse_enable has an effect, but not the right one.
The change "Add option flip_x #4555" seems to break the display. By the way, I use an esp8266, no esp32, but that should not matter.

This was referenced Apr 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants