Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Diameters should is a function the model grid domain, and it should reflect x-length / 2 (or equally y-length /2), but it currently doesn't! #11

Closed
eb-mars opened this issue Jun 15, 2021 · 2 comments

Comments

@eb-mars
Copy link
Collaborator

eb-mars commented Jun 15, 2021

Max Diameters should is a current of the model grid domain, and it should reflect x-length / 2 (or equally y-length /2).... but it currently does not reflect this and the biggest craters look small relative to the model domain.

This issue is probably within the code where the MinD and MaxD are set!

@eb-mars
Copy link
Collaborator Author

eb-mars commented Jun 15, 2021

ok so i'm thinking it should be:
minD = int(mg.area_of_cell[0]/mg.dx) * 3

i think maybe for maxD it should be:
maxD = int((mg.number_of_nodes)/4)
and that would give the max diameter as a half of the domain size?

  • create new local branch
  • edit code to reflect changes above
  • add, commit, push
  • pull request
  • merge
  • pull downstream

@eb-mars eb-mars changed the title Max Diameters should is a current of the model grid domain, and it should reflect x-length / 2 (or equally y-length /2) Max Diameters should is a function the model grid domain, and it should reflect x-length / 2 (or equally y-length /2), but it currently doesn't! Jun 15, 2021
@eb-mars eb-mars closed this as completed Jun 16, 2021
@eb-mars
Copy link
Collaborator Author

eb-mars commented Jun 16, 2021

Gaia solved this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant