Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need modification to be compatible with pytorch v0.4 #143

Closed
kan-bayashi opened this issue Apr 26, 2018 · 5 comments · Fixed by #250
Closed

Need modification to be compatible with pytorch v0.4 #143

kan-bayashi opened this issue Apr 26, 2018 · 5 comments · Fixed by #250
Assignees
Labels
Help wanted Need help

Comments

@kan-bayashi
Copy link
Member

Hi all,

Pytorch is updated to version 0.4.
It requires some change to migrate from 0.3.1 to 0.4.
See detail from following url.
http://pytorch.org/2018/04/22/0_4_0-migration-guide.html

@kan-bayashi kan-bayashi added the Help wanted Need help label Apr 26, 2018
@sw005320 sw005320 assigned sw005320 and ShigekiKarita and unassigned sw005320 Apr 28, 2018
@sw005320
Copy link
Contributor

This actually causes a problem when we install warp_ctc. @ShigekiKarita, can you fix it?
Easy solution is

pytorch: venv/bin/activate
        . venv/bin/activate && conda install pytorch==0.3.1 -c pytorch

@Peidong-Wang
Copy link
Contributor

Peidong-Wang commented May 14, 2018

Is upgrading to 0.4.0 a desired change? It may lose the compatibility to earlier versions of pytorch. @kan-bayashi

@kan-bayashi
Copy link
Member Author

@pozhijisi It's not desired change, but we have to move on pytorch v0.4 sooner or later due to the development of new functions.

@sw005320
Copy link
Contributor

@arendu may comment about this. We had discussions about this today.

@arendu-zz
Copy link

pytorch 4 has some significant changes compared to 3... maybe best to update after the workshop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Need help
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants