Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tts.sh: call to python script before sourcing path.sh #2858

Closed
saamc opened this issue Jan 8, 2021 · 4 comments
Closed

tts.sh: call to python script before sourcing path.sh #2858

saamc opened this issue Jan 8, 2021 · 4 comments
Labels
Bug bug should be fixed ESPnet2

Comments

@saamc
Copy link

saamc commented Jan 8, 2021

Bug Description

in the shell script tts.sh the python script print_args.py is invoked before the path is set up

print_args.py uses #!/usr/bin/env python and thus fails.

run_args=$(pyscripts/utils/print_args.py $0 "$@")

but path setup happens later on

. ./path.sh

Basic Environment

the issue was experienced in docker ESPnet so its environment applies

  • OS information: Linux 5.4.0-48-generic AMI recipe #52-Ubuntu SMP Thu Sep 10 10:58:49 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
  • Docker version: 20.10.1, build 831ebea
  • image: espnet/espnet:gpu-cuda10.1-cudnn7
  • espnet version: v.0.9.6
  • Git hash: 747c46d34cbba3e32bc99aecc49098c7d7ca30f5
    • Commit date: Tue Dec 1 12:09:32 2020 +0000

Task Information

  • task: TTS
  • recipe: VCTK
  • ESPnet2

Reproduction

cd docker
./run.sh --docker-egs vctk/tts1 --docker-folders ~/experiments/tts/data/VCTK --is-egs2 run.sh --stage 5 |& tee /tmp/run.log

log file: /tmp/run.log

Error Logs:

Using image espnet/espnet:gpu-cuda10.1-cudnn7-u18-user-user1.
Executing application in Docker
docker run --gpus '"device=0"' -i --rm --name espnet_gpu0_20210108T1527 -v /home/user1/experiments/tts/workspace/espnet/egs:/espnet/egs -v /home/user1/experiments/tts/workspace/espnet/espnet:/espnet/espnet -v /home/user1/experiments/tts/workspace/espnet/espnet2:/espnet/espnet2 -v /home/user1/experiments/tts/workspace/espnet/test:/espnet/test -v /home/user1/experiments/tts/workspace/espnet/utils:/espnet/utils -v /home/user1/experiments/tts/workspace/espnet/egs2:/espnet/egs2 -v /home/user1/experiments/tts/workspace/espnet/espnet2:/espnet/espnet2 -v /dev/shm:/dev/shm -v /home/user1/experiments/tts/data/VCTK:/home/user1/experiments/tts/data/VCTK espnet/espnet:gpu-cuda10.1-cudnn7-u18-user-user1 /bin/bash -c 'cd /espnet/egs2/vctk/tts1; ./run.sh --stage 5'
2021-01-08T15:27:11 (tts.sh:187:main) ./tts.sh --lang en --feats_type raw --fs 24000 --n_fft 2048 --n_shift 300 --win_length 1200 --token_type phn --cleaner tacotron --g2p g2p_en_no_space --train_config conf/train.yaml --inference_config conf/decode.yaml --train_set tr_no_dev --valid_set dev --test_sets dev eval1 --srctexts data/tr_no_dev/text --audio_format flac --stage 5
/usr/bin/env: 'python': No such file or directory
run.sh done.
@kamo-naoyuki kamo-naoyuki added the Bug bug should be fixed label Jan 8, 2021
@kamo-naoyuki
Copy link
Collaborator

Thanks.

I knew this problem, but it's inevitable. I will never fix this issue. Sorry.
Please also install Python at system.

@saamc
Copy link
Author

saamc commented Jan 9, 2021

Thank you for your reply.

While I don't know what the reason for this wontfix is, I'd like to remark that it seriously compromises the usability of the current docker images.

Installing python at system level means modifying the docker image. This has to be done manually or by modifying docker/prebuilt/Dockerfile.

Should I open a separate issue suggesting this?

@kamo-naoyuki
Copy link
Collaborator

Let me think.

@kamo-naoyuki
Copy link
Collaborator

I fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug bug should be fixed ESPnet2
Projects
None yet
Development

No branches or pull requests

2 participants