Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] EURO uasr scripts #4846

Merged
merged 20 commits into from Jan 14, 2023
Merged

[WIP] EURO uasr scripts #4846

merged 20 commits into from Jan 14, 2023

Conversation

DongjiGao
Copy link
Contributor

Revert the previous modification to tokenize_text.py script:

  • do tokenization only using tokenize_text
  • get vocabulary in later in pyscripts/text/combine_text_and_vocab.py

@mergify mergify bot added the ESPnet2 label Jan 1, 2023
@DongjiGao DongjiGao changed the title Uasr tokenization fixing [WIP] EURO uasr scripts Jan 1, 2023
@sw005320
Copy link
Contributor

sw005320 commented Jan 1, 2023

Thanks!
I just want to make sure the relationship between this PR and #4774.
Is it a part of #4774 or independent but necessary PR for #4774?

@sw005320 sw005320 added this to the v.202301 milestone Jan 1, 2023
@sw005320 sw005320 requested a review from ftshijt January 1, 2023 21:02
@ftshijt
Copy link
Collaborator

ftshijt commented Jan 1, 2023

This is a part of #4774. This PR will be included in that PR after merge (to uasr branch)

ftshijt
ftshijt reviewed Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues.

espnet2/uasr/generator/conv_generator.py Outdated Show resolved Hide resolved
espnet2/uasr/loss/smoothness_penalty.py Show resolved Hide resolved
ftshijt
ftshijt reviewed Jan 3, 2023
View reviewed changes
egs2/TEMPLATE/asr1/pyscripts/feats/apply_pca.py Outdated Show resolved Hide resolved
egs2/TEMPLATE/asr1/pyscripts/feats/apply_pca.py Outdated Show resolved Hide resolved
egs2/TEMPLATE/asr1/scripts/feats/feats_clustering.sh Outdated Show resolved Hide resolved
egs2/TEMPLATE/asr1/scripts/feats/feats_clustering.sh Outdated Show resolved Hide resolved
egs2/TEMPLATE/asr1/scripts/feats/feats_clustering.sh Outdated Show resolved Hide resolved
@ftshijt
Copy link
Collaborator

ftshijt commented Jan 11, 2023

Could you let me know if the PR is ready to merge? The PR LGTM! If the result is as expected, let's fix it and start to do the unit test/integration test/documentation.

@ftshijt ftshijt merged commit 6e353a4 into espnet:uasr Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftshijt ftshijt ftshijt left review comments

Assignees
No one assigned
Labels
ESPnet2 Unsupervise
Projects
None yet
Milestone
v.202301
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DongjiGao @sw005320 @ftshijt