Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player #5

Closed
5 tasks done
sturdy-robot opened this issue Jun 16, 2020 · 5 comments
Closed
5 tasks done

Player #5

sturdy-robot opened this issue Jun 16, 2020 · 5 comments
Assignees
Labels
done This is done! Hooray! enhancement New feature or request

Comments

@sturdy-robot
Copy link
Collaborator

sturdy-robot commented Jun 16, 2020

  • Date of Birth
  • Preferred Champions
  • Store Champion Skill Lvl
  • Improve Player Name Generation
  • Expand Player Nationality
@sturdy-robot sturdy-robot created this issue from a note in eSports Manager 0.1.0-alpha (To do) Jun 16, 2020
@sturdy-robot sturdy-robot added the enhancement New feature or request label Jun 16, 2020
@sturdy-robot sturdy-robot self-assigned this Jun 16, 2020
@sturdy-robot
Copy link
Collaborator Author

Player Nationality was extended with the commit 4def326
It can be used in player generation, and we could improve by creating something like "Region Generation", generating teams and players according to the region, but it is a start.
With that, Player Name Generation was also improved upon. We have a lot of names to choose from, including female ones. Currently only male ones are being generated, but there's nothing stopping us from creating female players!

@sturdy-robot
Copy link
Collaborator Author

I want to create a side project to scrape a web site like Liquipedia, to create a file with actual players names and nicknames, and get real team logos and names! That should be fun to do as well, and could potentially be used in the future, creating a very nice database of eSports players.

@sturdy-robot sturdy-robot moved this from To do to In progress in eSports Manager 0.1.0-alpha Aug 7, 2020
@sturdy-robot
Copy link
Collaborator Author

Date of Birth was implemented in d428121

On the way to implement champion skill level.

@sturdy-robot sturdy-robot added the In progress We are working on it label Nov 15, 2020
@sturdy-robot
Copy link
Collaborator Author

Champion skill level implemented.

Need some tests.

@sturdy-robot sturdy-robot moved this from In progress to Done in eSports Manager 0.1.0-alpha Dec 16, 2020
@sturdy-robot sturdy-robot reopened this Dec 16, 2020
eSports Manager 0.1.0-alpha automation moved this from Done to To do Dec 16, 2020
@sturdy-robot
Copy link
Collaborator Author

Players now have a champion skill level properly fixed and implemented. However, this will get all champion's multipliers, it should be a limited amount of champions, while all the others are going to be 0.55. I guess it's fine for now, but there's room for improvement.

eSports Manager 0.1.0-alpha automation moved this from To do to Done Dec 16, 2020
@sturdy-robot sturdy-robot mentioned this issue Dec 16, 2020
3 tasks
@sturdy-robot sturdy-robot added done This is done! Hooray! and removed In progress We are working on it labels Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This is done! Hooray! enhancement New feature or request
Development

No branches or pull requests

1 participant