Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WESP32 Rev7 or later #1136

Open
sommineer opened this issue Nov 29, 2023 · 3 comments
Open

Add support for WESP32 Rev7 or later #1136

sommineer opened this issue Nov 29, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sommineer
Copy link

Is your feature request related to a problem? Please describe.

The current configuration for the WESP32 (link) uses the ETH_PHY_LAN8720 for the ethernet module. However, according to the docs for WESP32, the ethernet module changed in Rev7 of the board to RTL8201. So those boards should be using ETH_PHY_RTL8201

Describe the solution you'd like

Add an option to select a specific option for Rev7 of the board

Describe alternatives you've considered

No response

Additional context

I can create a PR with the change if you'd like. I'm assuming the new entry would have to go at the end so we don't change the index of the existing configured items.

@sommineer sommineer added the enhancement New feature or request label Nov 29, 2023
@CV8R
Copy link

CV8R commented Dec 14, 2023

+1 WESP v7 are fantastic high quality boards.

@CV8R
Copy link

CV8R commented Mar 14, 2024

I have implemented the Rev 7 board in my fork and is working reliably for >48hrs. I added the changes to have the type appear in the Ethernet Type drop-down and also added a board type. The board type is added to define the default pin types which conflict with the defaults. There is a clear warning from the vendor that not configuring the pins correctly can result in damage.

Question - the placeholder values in the GUI still say the old values and I could not see a way to override those for the defined pins. I had confirmed via the log that the correct pins are used though.

Shall I create a pull request for the changes?

Incidentally, the risk is higher with the earlier board revisions, so the board type should probably be implemented there too but I do not have one of those to test with.

@CV8R
Copy link

CV8R commented Apr 10, 2024

Hi @DTTerastar okay to create a PR to add support for the wESP32rev7 board? My device has been working reliably since implementing the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants