Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3 + S3 Flash - CI test #6884

Closed
1 of 5 tasks
P-R-O-C-H-Y opened this issue Jun 20, 2022 · 5 comments · Fixed by #6916
Closed
1 of 5 tasks

C3 + S3 Flash - CI test #6884

P-R-O-C-H-Y opened this issue Jun 20, 2022 · 5 comments · Fixed by #6916
Assignees
Labels
Chip: ESP32-C3 Issue is related to support of ESP32-C3 Chip Chip: ESP32-S3 Issue is related to support of ESP32-S3 Chip Type: CI & Testing
Milestone

Comments

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Jun 20, 2022

Add flash testing to the GitHub CI. Following needs to be taken care of:

1st round:

  • Test files (sketch + test script)
  • Add option for tests_build.sh to accept flash_mode parameter
  • Add option to erase flash before uploading test to the chip
  • Make sure to call the test for each chip for each flash mode

2nd round:

  • Add Flash r/w performance test
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jun 20, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.4 milestone Jun 20, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added Chip: ESP32-C3 Issue is related to support of ESP32-C3 Chip Chip: ESP32-S3 Issue is related to support of ESP32-S3 Chip labels Jun 20, 2022
@P-R-O-C-H-Y
Copy link
Member Author

Adding @Ouss4, so we can discuss if needed here.

@lbernstone
Copy link
Contributor

Maybe add a small r/w benchmark to keep an eye for any major issues that affect flash performance?

@P-R-O-C-H-Y
Copy link
Member Author

@lbernstone Good idea, we can add some test for r/w performance. Adding that to the list.

@igrr
Copy link
Member

igrr commented Jun 20, 2022

Just 2c, there is a benchmarking test for flash performance in several different mode in esp-idf CI. The problem is that it is extremely unreliable:

  • different flash chips of the same type may have varying erase times
  • erase times get significantly longer over the lifetime of the part (in CI the flash chips get a lot of wear)

Given that Arduino-esp32 pretty much directly calls the underlying IDF flash related functions, i think the likelihood of a performance regression is low, while the effort to maintain such a performance test would be relatively high.

@me-no-dev
Copy link
Member

The one thing I see worth testing as speed is to make sure that there is actually a difference between the flash modes. With the latest findings (and until we fix this in the lib-builder) it seems to me that there is a chance that flash modes actually do not correspond to what is being set and enabled by the bootloader. @igrr do you thing that such test makes sense and will work, regradles of the flash chip differences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chip: ESP32-C3 Issue is related to support of ESP32-C3 Chip Chip: ESP32-S3 Issue is related to support of ESP32-S3 Chip Type: CI & Testing
Projects
Development

Successfully merging a pull request may close this issue.

6 participants