Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable name confusion in csi_data_read_parse.py file (AEGHB-723) #187

Open
TryTwoTop opened this issue Jul 4, 2024 · 1 comment
Open

Comments

@TryTwoTop
Copy link

File path: esp-csi / examples / get-started / tools / csi_data_read_parse.py

Is it correct to change from phase to amplitude in the variable name self.csi_phase_array?

*Link
https://github.com/espressif/esp-csi/blob/master/examples/get-started/tools/csi_data_read_parse.py#L85

@github-actions github-actions bot changed the title Variable name confusion in csi_data_read_parse.py file Variable name confusion in csi_data_read_parse.py file (AEGHB-723) Jul 4, 2024
@suhipek
Copy link

suhipek commented Jul 16, 2024

I think you're correct. Indeed the result of np.abs(csi_data_array) should be its amplitudes. We will fix this typo in upcoming updates. Thank you for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants