Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TW#12276] AP: Add a way to control which DNS server is offered to clients #162

Closed
rojer opened this issue Dec 14, 2016 · 7 comments
Closed

Comments

@rojer
Copy link
Contributor

rojer commented Dec 14, 2016

At the moment from reading the code i see that device's address is always offered as the DNS server.
There should be a way to control whether server is offered at all and if so, which IP.

@FayeY FayeY changed the title AP: Add a way to control which DNS server is offered to clients [TW#12276] AP: Add a way to control which DNS server is offered to clients May 4, 2017
@liuzfesp
Copy link
Contributor

liuzfesp commented Jun 7, 2017

HI @rojer, a new menuconfig is added to configure whether the default dns server will be configured or not, if enabled, the dns server address got from DHCP ACK's option "Host Domain Name" will be set as default DNS server, otherwise, the address in DHCP Ack's option will be ignore and the user need to configure the DNS server. I think the code will be ready in next release, maybe release2.1

@rojer
Copy link
Contributor Author

rojer commented Jun 7, 2017

this issue is about which server ESP AP offers to clients, i.e. the behavior of its DHCP server, while you seem to be talking about ESP's STA DHCP client behavior.

the original reason for this issue is that it is not always that when i connect to ESP AP i also want my traffic to go trough it (router option) or for it to be used a s a DNS server (DNS option). in fact, i'd argue that in most cases AP is used to provision the device, so it should default to no routing and no DNS, so that user retains their original internet connection.

@rojer
Copy link
Contributor Author

rojer commented Jun 7, 2017

in any case, it should be possible to turn off DNS and router options in the server responses. it's already possible with router, DNS still remains.

@liuzfesp
Copy link
Contributor

liuzfesp commented Jun 7, 2017

Thanks @rojer for clarification, then I'm going to add options to DNS server option for AP side.

@rojer
Copy link
Contributor Author

rojer commented Jun 7, 2017

good, thanks!

@FayeY
Copy link
Collaborator

FayeY commented Jul 5, 2017

Is this problem solved in the latest ESP-IDF?

@rojer
Copy link
Contributor Author

rojer commented Jul 5, 2017

as far as i can tell, no. @liuzfesp ?

@igrr igrr closed this as completed in cf7ae81 Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants