Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2S documentation refers to non-existent i2s_adc_start/stop() functions (IDFGH-578) #2978

Closed
detly opened this issue Jan 21, 2019 · 4 comments

Comments

@detly
Copy link

detly commented Jan 21, 2019

The documentation for I2S, specifically the is2_read() function, refers to functions i2s_adc_start and i2s_adc_stop:

Note: If the built-in ADC mode is enabled, we should call i2s_adc_start and i2s_adc_stop around the whole reading process, to prevent the data getting corrupted.

These functions don't appear anywhere in the source code (for I2S or the whole IDF library as far as I can tell).

@Alvin1Zhang Alvin1Zhang changed the title I2S documentation refers to non-existent i2s_adc_start/stop() functions [TW#28485] I2S documentation refers to non-existent i2s_adc_start/stop() functions Jan 22, 2019
@itaisod
Copy link

itaisod commented Feb 18, 2019

Indeed.

@projectgus projectgus changed the title [TW#28485] I2S documentation refers to non-existent i2s_adc_start/stop() functions I2S documentation refers to non-existent i2s_adc_start/stop() functions (IDFGH-578) Mar 12, 2019
@mehmetcanbalci-Notrino
Copy link

They are doing deliberately

@giPeteR
Copy link

giPeteR commented Apr 15, 2020

I'm having a hard time getting the I2S ADC DMA to work in >4.0.
Confusing documentation still mentioning i2s_adc_start and i2s_adc_stop doesn't help:
https://docs.espressif.com/projects/esp-idf/en/release-v4.1/api-reference/peripherals/i2s.html

The example:
\examples\peripherals\i2s_adc_dac
works in 4.0, but in 4.2-dev the ADC works about every 4'th reset, DAC never works.

@koobest
Copy link
Contributor

koobest commented Apr 15, 2020

Hi,@detly
We will update the DOC
@giPeteR
Can you please open a new issue?

thanks !!

@igrr igrr closed this as completed in b35d900 Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants