New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPONENT_SRCS doesn't work with spaces #3130

Closed

DavidAustin opened this issue Mar 5, 2019 · 1 comment

DavidAustin commented Mar 5, 2019

Environment

Module or chip used: ESP32-WROOM-32D
IDF version: v3.3-beta2-18-g0f927791b
Build System: CMake
Operating System: Linux
Power Supply: N/A

Problem Description

The CMake variable COMPONENT_SRCS doesn't support spaces. It
should, as documented here: https://docs.espressif.com/projects/esp-idf/en/latest/api-guides/build-system-cmake.html#minimal-component-cmakelists

Adding

spaces2list(COMPONENT_SRCS)

to line 23 of esp-idf/tools/cmake/components.cmake fixes this bug.

The text was updated successfully, but these errors were encountered:

Collaborator

suda-morris commented Mar 6, 2019 •

edited

Thanks @DavidAustin . Yes it's a bug. It doesn't coincide with the document. We'll fix it ASAP.

igrr closed this as completed in

9297b07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment