Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWIP header missing C++ guards (IDFGH-1403) #3681

Closed
jeremyherbert opened this issue Jun 23, 2019 · 3 comments
Closed

LWIP header missing C++ guards (IDFGH-1403) #3681

jeremyherbert opened this issue Jun 23, 2019 · 3 comments

Comments

@jeremyherbert
Copy link
Contributor

jeremyherbert commented Jun 23, 2019 •
edited

Hi,

It seems that lwip/include/netif/ppp/ppp.h and lwip/include/netif/ppp/pppos.h are both missing C++ guards; there could be more, I haven't checked all of the files. Interestingly, these guards are all present in the latest LWIP source from the GNU savannah page.

This of course causes PPPoS to not link properly with C++ code due to name mangling.
@github-actions github-actions bot changed the title LWIP header missing C++ guards LWIP header missing C++ guards (IDFGH-1403) Jun 23, 2019
@zhangyanjiaoesp
Copy link
Collaborator

@jeremyherbert Thank you very much for pointing out our problems. We will check the LWIP headers and add the C++ guards.

@AxelLin
Copy link
Contributor

AxelLin commented Feb 1, 2020

This is already fixed in IDF master tree.

@AxelLin
Copy link
Contributor

AxelLin commented Feb 12, 2020

@Alvin1Zhang This is already fixed and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremyherbert @AxelLin @zhangyanjiaoesp