Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_eth.c ETH_CHECK order problem (IDFGH-2829) #4890

Closed
sbela opened this issue Mar 5, 2020 · 1 comment
Closed

esp_eth.c ETH_CHECK order problem (IDFGH-2829) #4890

sbela opened this issue Mar 5, 2020 · 1 comment
Assignees

Comments

@sbela
Copy link

sbela commented Mar 5, 2020

I think that from esp_eth.c:290

   esp_eth_driver_t *eth_driver = (esp_eth_driver_t *)hdl;
    eth_driver->priv = priv;
    ETH_CHECK(eth_driver, "ethernet driver handle can't be null", err, ESP_ERR_INVALID_ARG);

should be

   esp_eth_driver_t *eth_driver = (esp_eth_driver_t *)hdl;
    ETH_CHECK(eth_driver, "ethernet driver handle can't be null", err, ESP_ERR_INVALID_ARG);       
    eth_driver->priv = priv;

@github-actions github-actions bot changed the title esp_eth.c ETH_CHECK order problem esp_eth.c ETH_CHECK order problem (IDFGH-2829) Mar 5, 2020
@suda-morris
Copy link
Collaborator

well spotted! We will fix it soon. Thanks.

@suda-morris suda-morris self-assigned this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants