Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending questions to MDNS responses breaks Avahi-Daemon (IDFGH-5736) #7453

Closed
d8ahazard opened this issue Aug 21, 2021 · 4 comments
Closed
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@d8ahazard
Copy link

This is to loop in this library on the discussion being had here:

Aircoookie/WLED#2009 (comment)

and here:

avahi/avahi#348

Basically, the esp-mdns implementation is echoing th question message in responses, which causes avahi-daemon to discard the response as invalid.

I can see this happening here at line 1085:

https://github.com/espressif/esp-idf/blob/master/components/mdns/mdns.c

Apparently, the proper approach as per the RFC for MDNS is to ignore these responses, so it would stand to reason that the behavior on this side is fine, but I just wanted to link it to the other issues for completeness.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 21, 2021
@github-actions github-actions bot changed the title Appending questions to MDNS responses breaks Avahi-Daemon Appending questions to MDNS responses breaks Avahi-Daemon (IDFGH-5736) Aug 21, 2021
@negativekelvin
Copy link
Contributor

#7124

@david-cermak
Copy link
Collaborator

@negativekelvin Thanks for the reference

@d8ahazard This bug was fixed as

Please update the IDF version to include the above commits. It's also possible to work around this bug setting

@david-cermak
Copy link
Collaborator

@d8ahazard Could you please close the issue?

@Alvin1Zhang
Copy link
Collaborator

Thanks for reporting, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

5 participants