Skip to content

Commit 1fe901f

Browse files
global: fix sign-compare warnings
* Original commit: espressif/esp-idf@753a929
1 parent 2cf9fd8 commit 1fe901f

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

components/mdns/mdns.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1605,7 +1605,7 @@ static void _mdns_init_pcb_probe(mdns_if_t tcpip_if, mdns_ip_protocol_t ip_proto
16051605
mdns_srv_item_t * new_probe_services[len];
16061606
int new_probe_service_len = 0;
16071607
bool found;
1608-
for (int j=0; j < len; ++j) {
1608+
for (size_t j=0; j < len; ++j) {
16091609
found = false;
16101610
for (int i=0; i < pcb->probe_services_len; ++i) {
16111611
if (pcb->probe_services[i] == services[j]) {
@@ -2508,11 +2508,10 @@ static int _mdns_txt_items_count_get(const uint8_t * data, size_t len)
25082508
*/
25092509
static int _mdns_txt_item_name_get_len(const uint8_t * data, size_t len)
25102510
{
2511-
int i;
25122511
if (*data == '=') {
25132512
return -1;
25142513
}
2515-
for (i = 0; i < len; i++) {
2514+
for (size_t i = 0; i < len; i++) {
25162515
if (data[i] == '=') {
25172516
return i;
25182517
}
@@ -3483,7 +3482,6 @@ static void _mdns_search_result_add_srv(mdns_search_once_t * search, const char
34833482
*/
34843483
static void _mdns_search_result_add_txt(mdns_search_once_t * search, mdns_txt_item_t * txt, size_t txt_count, mdns_if_t tcpip_if, mdns_ip_protocol_t ip_protocol)
34853484
{
3486-
int i;
34873485
mdns_result_t * r = search->result;
34883486
while (r) {
34893487
if (r->tcpip_if == tcpip_if && r->ip_protocol == ip_protocol) {
@@ -3515,7 +3513,7 @@ static void _mdns_search_result_add_txt(mdns_search_once_t * search, mdns_txt_it
35153513
return;
35163514

35173515
free_txt:
3518-
for (i=0; i<txt_count; i++) {
3516+
for (size_t i=0; i<txt_count; i++) {
35193517
free((char *)(txt[i].key));
35203518
free((char *)(txt[i].value));
35213519
}
@@ -4702,15 +4700,14 @@ void mdns_query_results_free(mdns_result_t * results)
47024700
{
47034701
mdns_result_t * r;
47044702
mdns_ip_addr_t * a;
4705-
int i;
47064703

47074704
while (results) {
47084705
r = results;
47094706

47104707
free((char *)(r->hostname));
47114708
free((char *)(r->instance_name));
47124709

4713-
for (i=0; i<r->txt_count; i++) {
4710+
for (size_t i=0; i<r->txt_count; i++) {
47144711
free((char *)(r->txt[i].key));
47154712
free((char *)(r->txt[i].value));
47164713
}

components/mdns/mdns_console.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ static void mdns_print_results(mdns_result_t * results)
2424
{
2525
mdns_result_t * r = results;
2626
mdns_ip_addr_t * a = NULL;
27-
int i = 1, t;
27+
int i = 1;
2828
while (r) {
2929
printf("%d: Interface: %s, Type: %s\n", i++, if_str[r->tcpip_if], ip_protocol_str[r->ip_protocol]);
3030
if (r->instance_name) {
@@ -35,7 +35,7 @@ static void mdns_print_results(mdns_result_t * results)
3535
}
3636
if (r->txt_count) {
3737
printf(" TXT : [%u] ", r->txt_count);
38-
for (t=0; t<r->txt_count; t++) {
38+
for (size_t t=0; t<r->txt_count; t++) {
3939
printf("%s=%s; ", r->txt[t].key, r->txt[t].value);
4040
}
4141
printf("\n");

0 commit comments

Comments
 (0)