Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings with pedantic flags #526

Closed
tore-espressif opened this issue Apr 3, 2023 · 3 comments
Closed

Build warnings with pedantic flags #526

tore-espressif opened this issue Apr 3, 2023 · 3 comments

Comments

@tore-espressif
Copy link
Contributor

Pedantic build with following compile options fails

export PEDANTIC_FLAGS="-DIDF_CI_BUILD -Werror -Werror=deprecated-declarations -Werror=unused-variable -Werror=unused-but-set-variable -Werror=unused-function"
export PEDANTIC_CFLAGS="${PEDANTIC_FLAGS} -Wstrict-prototypes"
export PEDANTIC_CXXFLAGS="${PEDANTIC_FLAGS}"
export EXTRA_CFLAGS=${PEDANTIC_CFLAGS}
export EXTRA_CXXFLAGS=${PEDANTIC_CXXFLAGS}

Could you please fix the build warnings or disable the warnings (-Wno-strict-prototypes should help)

Related espressif/esp-bsp#51

@me-no-dev
Copy link
Member

@tore-espressif can I add this somehow to our CI?Manually building it does not seem like ling term solution.

@tore-espressif
Copy link
Contributor Author

I prepared a PR here #529

@github-actions
Copy link

This issue appears to be stale. Please close it if its no longer valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants