Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support build-in USB-JTAG-Serial #54

Merged
merged 2 commits into from Jan 12, 2023
Merged

support build-in USB-JTAG-Serial #54

merged 2 commits into from Jan 12, 2023

Conversation

liux-pro
Copy link
Contributor

@liux-pro liux-pro commented Dec 2, 2022

esp32c3 esp32s3 have a built-in USB serial.
When connect them direct by usb, without external usb-serial-bridge(ch340 etc.), send correct sequence of handshake signals can put the chip into download mode.
The specific sequence can be found from esp32s3 datasheet 33.4.2 Runtime operation.

@igrr
Copy link
Member

igrr commented Dec 6, 2022

@liux-pro Thank you very much for this useful PR! We have just merged #53 which was a big refactoring that moved all the code to Typescript. Would you mind rebasing or reapplying your changes? Sorry for the hassle!

@igrr igrr linked an issue Dec 6, 2022 that may be closed by this pull request
@liux-pro
Copy link
Contributor Author

liux-pro commented Dec 6, 2022

Hi @igrr
I apply changes to typescript.
Besides,I think this PR is not related to #41. This PR focus on reboot device and enter flash mode, however, #41 is already in download mode, and uploaded stub successfully.

@robert-alfaro
Copy link

robert-alfaro commented Dec 22, 2022

@igrr / @ameyinamdar Is this clear to merge now?

@igrr
Copy link
Member

igrr commented Jan 12, 2023

Thanks for the PR @liux-pro, and sorry to keep you waiting.

I have rebased and force-pushed to the branch of this PR, getting rid of the merge commit and adding a small fix related to the previous PR. Have tested this on ESP32-C3 and ESP32-S3 and both work fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants