Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: Failed building wheel for reedsolo (ESPTOOL-217) #615

Closed
Franky1 opened this issue Mar 21, 2021 · 4 comments
Closed

ERROR: Failed building wheel for reedsolo (ESPTOOL-217) #615

Franky1 opened this issue Mar 21, 2021 · 4 comments

Comments

@Franky1
Copy link

Franky1 commented Mar 21, 2021

  • Operating system:
  • Python version:

Microsoft Windows 10 Home x64
Python 3.8.6

Full esptool.py command line as run:

pip install --upgrade esptool

Full output from esptool.py

Building wheel for reedsolo (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: 'C:\WinPython\WPy64-3860\python-3.8.6.amd64\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\xxxxx\\AppData\\Local\\Temp\\pip-install-7t324qen\\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\\setup.py'"'"'; __file__='"'"'C:\\Users\\xxxxx\\AppData\\Local\\Temp\\pip-install-7t324qen\\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d 'C:\Users\xxxxx\AppData\Local\Temp\pip-wheel-u8lvkz0w'
       cwd: C:\Users\xxxxx\AppData\Local\Temp\pip-install-7t324qen\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\
  Complete output (10 lines):
  Cython is installed, building creedsolo module
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win-amd64-3.8
  copying reedsolo.py -> build\lib.win-amd64-3.8
  running build_ext
  building 'creedsolo' extension
  error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
  ----------------------------------------
  ERROR: Failed building wheel for reedsolo
  Running setup.py clean for reedsolo
Failed to build reedsolo
Installing collected packages: reedsolo, ecdsa, bitstring, esptool
    Running setup.py install for reedsolo ... error
    ERROR: Command errored out with exit status 1:
     command: 'C:\WinPython\WPy64-3860\python-3.8.6.amd64\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\xxxxx\\AppData\\Local\\Temp\\pip-install-7t324qen\\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\\setup.py'"'"'; __file__='"'"'C:\\Users\\xxxxx\\AppData\\Local\\Temp\\pip-install-7t324qen\\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record 'C:\Users\xxxxx\AppData\Local\Temp\pip-record-pggpxbrh\install-record.txt' --single-version-externally-managed --compile --install-headers 'C:\WinPython\WPy64-3860\python-3.8.6.amd64\Include\reedsolo'
         cwd: C:\Users\xxxxx\AppData\Local\Temp\pip-install-7t324qen\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\
    Complete output (10 lines):
    Cython is installed, building creedsolo module
    running install
    running build
    running build_py
    creating build
    creating build\lib.win-amd64-3.8
    copying reedsolo.py -> build\lib.win-amd64-3.8
    running build_ext
    building 'creedsolo' extension
    error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
    ----------------------------------------
ERROR: Command errored out with exit status 1: 'C:\WinPython\WPy64-3860\python-3.8.6.amd64\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\xxxxx\\AppData\\Local\\Temp\\pip-install-7t324qen\\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\\setup.py'"'"'; __file__='"'"'C:\\Users\\xxxxx\\AppData\\Local\\Temp\\pip-install-7t324qen\\reedsolo_36fa3459e2704df38ef5a96a1dde4c14\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record 'C:\Users\xxxxx\AppData\Local\Temp\pip-record-pggpxbrh\install-record.txt' --single-version-externally-managed --compile --install-headers 'C:\WinPython\WPy64-3860\python-3.8.6.amd64\Include\reedsolo' Check the logs for full command output.

What is the expected behaviour?

pip upgrade should not fail and should install with pre-build wheels without the need to install additional ms toolchains

Do you have any other information from investigating this?

No

@Franky1 Franky1 added the bug label Mar 21, 2021
@github-actions github-actions bot changed the title ERROR: Failed building wheel for reedsolo ERROR: Failed building wheel for reedsolo (ESPTOOL-217) Mar 21, 2021
@dobairoland
Copy link
Collaborator

Hi @Franky1. I see that you've reported this issue for the reedsolo package as well (tomerfiliba-org/reedsolomon#32). This is very weird and I think something is wrong with your Python. We are using Python 3.8.7 as the default one for ESP-IDF where this package is installed and used by many customers. I have no information beside yours that Visual C++ would be required. I don't have it neither and have it with 3.8.7.

Do you have some special distribution of Python? Could you please try one 3.8.x from python.org? 3.9.x is the newest one but lets keep trying to debug 3.8.x.

@Franky1
Copy link
Author

Franky1 commented Mar 22, 2021

I am usually using WinPython distributions for all of my windows machines:
https://winpython.github.io/

I suspect something is broken with this particular WinPython version.
I just tried it on another computer with 3.7.7, there pip install --upgrade esptool worked without errors.

@dobairoland
Copy link
Collaborator

Great! I'm happy that you've found a workaround which works for you.

I think we can close this because we don't handle Python selection at the Esptool level.

@Franky1
Copy link
Author

Franky1 commented Mar 23, 2021

Still after switching from WinPython 3.8.6.0 to WinPython 3.8.8.0 on this machine, i had no success to install esptool respectively reedsolo.

Only after installing the latest Microsoft Visual C++ 14.2 Build Tools on this machine I was able to install esptool respectively reedsolo without any error messages.

https://wiki.python.org/moin/WindowsCompilers

I still wondered why a ready-made wheel is not taken instead.
It could be because for reedsolo currently only one wheel is provided for Python 3.7

https://pypi.org/project/reedsolo/#files

That's why my attempts under 3.8.x.x all failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants