-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to PyPI. #63
Comments
This sounds like a great idea. I have never uploaded anything to PyPI before. Are you in a position to give any advice about whether esptool is ready for submission in its current state, or should other checks be done? Angus |
What about this for example: https://github.com/SuperHouse/esp-open-rtos/blob/master/lib/symbols_norename.txt#L1 ? |
Hi @pfalcon, Sorry, did you mean to leave this comment somewhere else? It's not clear to me how it relates to PyPI submission. However, thanks for pointing that line in esp-open-rtos out. esptool.py no longer hardcodes the entry point name, as of #52 it's loaded from the ELF file. In esp-open-rtos that |
Nope, I meant to leave it here - I believed that issue was fixed, but as I was found to mix up things, I'd let you to confirm it (before publishing to pypi without that patch possibly merged).
Cool, one issue confirmed fixed, another is fixed. ;-) |
What I would change before submitting to PyPI would be to make the script be called |
Good suggestions, thanks @skorokithakis.
I think that's a failure in documentation, in either case. :) |
Haha, possibly, but it may be out of scope for esptool. |
Keep in mind that there's another "esptool". I believe it's not even maintained by the original author, but it was picked up by folks who like to ship binaries in peoples' faces. Then more community-concious of them call it "esptool-ck", but I'm not sure if everyone does. And then the best thing this project can do keep people from confusion is to continue being called esptool.py . |
Sure, that's up to you. All I have is this esptool, but if you guys think that a collision has a reasonable chance of occurring, |
Can you do a
python setup.py sdist upload
so esptool gets published to PyPI? Then we'd be able to install it with just apip install esptool
.The text was updated successfully, but these errors were encountered: