Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffering for input stream and screen updates #1

Closed
MightyPork opened this issue Jan 23, 2017 · 1 comment
Closed

Add buffering for input stream and screen updates #1

MightyPork opened this issue Jan 23, 2017 · 1 comment

Comments

@MightyPork
Copy link
Member

Currently each character is sent to the parser state machine individually and each access to the screen generates an individual screen update event (and a socket broadcast).

This is wasteful.

We can buffer those for some time and then process sequentially. That could be done with a buffer, and trigger the event / parser when

(a) some time passes (20 ms?)
(b) the buffer is full

The ESP is fast so this is not really a big deal and can be left as is, but we can do better

@MightyPork MightyPork changed the title String / screen update event buffering with timeout Add buffering for input stream and screen updates Jan 23, 2017
@MightyPork
Copy link
Member Author

Implemented in sending from ESP to screen with throttling, still not implemented for USART rx.
Probably a waste of time to try to improve that, the UART is slow and we're fast.

Closing until a real performance issue arises.

@MightyPork MightyPork removed this from Completed in Settings Overhaul Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant