Plot configurations #456
Merged
Plot configurations #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PavelBal
commented
Jun 13, 2023
•
PavelBal
commented
- Calculate output figures height dynamically based on the number of rows
- Close Suggestions for default plot configuration #420
- Fixes DefaultPlotConfiguration - y-axis tic labels horizontally #413
- Fixes DefaultPlotConfiguration - esqlabs colors #414
+ reorganized content
…ration manipulations
Merge commit 'e1cc2a63567be7ebbb1e0429f36b2d3f24b4cc41'
+ improve figure outputs
…absR into plot-configurations
…configurations
…formative error message
…/esqLABS/esqlabsR into plot-configurations
Fix bug where plot grid name was used as title
…absR into plot-configurations
…absR into plot-configurations
|
@Felixmil Should review this after merging others. |
Felixmil
requested changes
Jul 19, 2023
| #' @export | ||
| #' @import ggplot2 | ||
| #' @family PlotConfiguration classes | ||
| ExportConfiguration <- R6::R6Class( |
There was a problem hiding this comment.
In this case, I don't think so because it comes from another package.
Revert order of dependencies
Felixmil
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.