Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save load results with slashes #548

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Save load results with slashes #548

merged 5 commits into from
Sep 26, 2023

Conversation

PavelBal
Copy link
Member

Fixes #547

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #548 (75eec28) into main (1c21e15) will increase coverage by 1.73%.
The diff coverage is 100.00%.

❗ Current head 75eec28 differs from pull request most recent head 116405a. Consider uploading reports for the commit 116405a to get more accurate results

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   82.12%   83.85%   +1.73%     
==========================================
  Files          30       30              
  Lines        1818     1821       +3     
==========================================
+ Hits         1493     1527      +34     
+ Misses        325      294      -31
Files Coverage Δ
R/utilities-scenarios.R 82.52% <100.00%> (+31.52%) ⬆️

Felixmil
Felixmil reviewed Sep 26, 2023
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
Felixmil
Felixmil requested changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@Felixmil Felixmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run pkgdown::build_news()

PavelBal and others added 3 commits September 26, 2023 16:59
@PavelBal @Felixmil
Update NEWS.md
595b4fc 
Co-authored-by: Felix MIL <34234913+Felixmil@users.noreply.github.com>
@PavelBal @Felixmil
Update tests/testthat/test-utilities-scenarios.R
b90e0f4 
Co-authored-by: Felix MIL <34234913+Felixmil@users.noreply.github.com>
@PavelBal
Build news
116405a
@PavelBal
Copy link
Member Author

run pkgdown::build_news()

Done.

Felixmil
Felixmil requested changes Sep 26, 2023
View reviewed changes
DESCRIPTION Show resolved Hide resolved
@PavelBal PavelBal merged commit 21c9523 into main Sep 26, 2023
1 check passed
@PavelBal PavelBal deleted the save_load_results_with-slashes branch September 26, 2023 15:54
@Felixmil Felixmil mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felixmil Felixmil Felixmil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot save or load results for scenario names containing slashes
2 participants
@PavelBal @Felixmil