Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if plotID (used in a plotGrid) is not unique #568

Conversation

Felixmil
Copy link
Collaborator

@Felixmil Felixmil commented Nov 6, 2023

fixes #566

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b171d0) 84.40% compared to head (6175c19) 84.46%.
Report is 4 commits behind head on main.

❗ Current head 6175c19 differs from pull request most recent head 69079c5. Consider uploading reports for the commit 69079c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   84.40%   84.46%   +0.06%     
==========================================
  Files          30       30              
  Lines        1827     1835       +8     
==========================================
+ Hits         1542     1550       +8     
  Misses        285      285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…duplicated-entries-for-plotgrids-or-plotconfiguration-exist
Copy link
Member

@PavelBal PavelBal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also field name in the sheet plotGrids

…duplicated-entries-for-plotgrids-or-plotconfiguration-exist
@PavelBal PavelBal merged commit 18fb438 into main Nov 16, 2023
1 of 2 checks passed
@PavelBal PavelBal deleted the 566-createplotsfromexcel-show-an-error-when-duplicated-entries-for-plotgrids-or-plotconfiguration-exist branch November 16, 2023 09:56
@Felixmil Felixmil mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createPlotsFromExcel()- show an error when duplicated entries for plotGrids or plotConfiguration exist
2 participants