Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createPlotsFromExcel can now handle empty rows excel configuration files #569

Merged
merged 1 commit into from
Nov 8, 2023
Merged

createPlotsFromExcel can now handle empty rows excel configuration files #569

merged 1 commit into from
Nov 8, 2023

Conversation

Felixmil
Copy link
Collaborator

@Felixmil Felixmil commented Nov 7, 2023 •
edited
Loading

fixes #562

@Felixmil
createPlotsFromExcel can now handle empty rows in dataCombined, plotC…
a0a509b 
…onfiguration, plotGrids and exportConfiguration

+ add test
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #569 (452708b) into main (4b171d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 452708b differs from pull request most recent head a0a509b. Consider uploading reports for the commit a0a509b to get more accurate results

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   84.40%   84.41%   +0.01%     
==========================================
  Files          30       30              
  Lines        1827     1829       +2     
==========================================
+ Hits         1542     1544       +2     
  Misses        285      285
Files Coverage Δ
R/utilities-figures.R 96.83% <100.00%> (+0.02%) ⬆️

@Felixmil Felixmil merged commit 8e9c2df into main Nov 8, 2023
1 check passed
@Felixmil Felixmil deleted the support_empty_rows_in_excel_files branch November 8, 2023 16:06
@Felixmil Felixmil mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelBal PavelBal PavelBal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createPlotsFromExcel() should support empty rows
2 participants
@Felixmil @PavelBal