Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringExtensions -> CapitalizeFirst #146

Closed
piv199 opened this issue Jun 27, 2016 · 2 comments · Fixed by #149
Closed

StringExtensions -> CapitalizeFirst #146

piv199 opened this issue Jun 27, 2016 · 2 comments · Fixed by #149

Comments

@piv199
Copy link
Collaborator

piv199 commented Jun 27, 2016

add please at first line

guard characters.count > 0 else { return self }

because String().capitalizeFirst crashes the program. If someone would like to check on client side it's good but if someone not, it's not the expected behaviour to crash the program
@Esqarrouth
Copy link
Owner

Can you send a pull request with this?

@lfarah
Copy link
Collaborator

lfarah commented Jun 28, 2016

I'll work on it

@lfarah lfarah mentioned this issue Jun 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes capitalizeFirst in StringExtensions
3 participants
@Esqarrouth @lfarah @piv199