Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display user/password & cert password prompts as an alert #115

Closed
dfeinzimer opened this issue Aug 8, 2022 · 7 comments · Fixed by #126
Closed

Display user/password & cert password prompts as an alert #115

dfeinzimer opened this issue Aug 8, 2022 · 7 comments · Fixed by #126
Assignees
Labels
enhancement New feature or request

Comments

@dfeinzimer
Copy link
Collaborator

Having the views presented via alert would likely be a more standard UX. (username/password prompt, certificate password prompt)

E.g. Replace this:

0f5dbd99-7138-4146-9387-9cb4e90b9657

with something close to this:

Screen Shot 2022-08-08 at 10 34 04

Reference: Common Toolkit #202

@dfeinzimer dfeinzimer added the enhancement New feature or request label Aug 8, 2022
@dfeinzimer dfeinzimer self-assigned this Aug 15, 2022
@dfeinzimer
Copy link
Collaborator Author

@rolson I'm looking at doing this now but seeing that TextFields are only supported within alerts in iOS 16+.

I assume our minimum supported iOS will be < 16 for 200? If so, we'd need to either:

  1. Support two implementations (yours and one for iOS 16+)
  2. Roll our own "alert" view in SwiftUI
  3. Use a UIKit UIAlertController via UIViewControllerRepresentable

Personally, I like the LoginView you created and prefer it to a simple alert with text fields.

Any thoughts @mhdostal?

@rolson
Copy link
Contributor

rolson commented Aug 16, 2022

My personal preference for me would be an alert. However, the apps team is requesting this change and we would want to make sure we are aligned with the UX that they prefer so that they use these components.

In terms of iOS 16, you will need to talk to @dg0yal and @ldanzinger about that.

@mhdostal
Copy link
Member

However, the apps team is requesting this change

What is the Apps team's preference?

@rolson
Copy link
Contributor

rolson commented Aug 16, 2022

Alerts

@mhdostal
Copy link
Member

I also like the LoginView, but it is full-screen and quite intrusive, so my vote is for Alert.

How about using the native Alert for iOS 16, but using the UIAlertController and UIViewControllerRepresentable for iOS 15?

@rolson
Copy link
Contributor

rolson commented Aug 16, 2022

Sounds good to me

@dfeinzimer dfeinzimer mentioned this issue Aug 17, 2022
@dfeinzimer dfeinzimer linked a pull request Aug 17, 2022 that will close this issue
@dfeinzimer
Copy link
Collaborator Author

Closing, completed with #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants