-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error icon for Basemaps that we know will not work. #54
Comments
I have a branch that does that here. It needs to be fixed so the icon isn't cut off. |
cc: @dfeinzimer |
I like 1. Another idea: what about putting the exclamation mark at the center of the thumbnail? Did a quick look up in HIG but didn't find anything related. |
At first I liked option 2 better because I felt the larger tiles preserved more details in the previews but now I think the consistent sizing in option 3 looks better. I might be misremembering but didn't we remove the red we had before in PR 39 because Eric suggested it may be too distracting? |
That's right, we did have something similar. Sorry, I forgot about that. I do think the right sizing of this element is important if we choose to go with it. I think smaller and we can get an idea by how iOS uses it. Looking how it is used in the iOS home screen, the size the icon takes up is not part of the size of the button. It is eating into the space between the buttons. That's important for getting the spacing and sizing right. |
I like it |
We have a a few Basemaps hard-coded that we know will fail. The user should rarely see this in practice as most maps are WM |
I'm liking the Basemaps gallery. I have an idea for an enhancement that I think would be nice.
When you select a basemap for the first time, it does some loading, and it might determine that the basemap is not valid:
That's great.
After that, however, can we add a little red circle in the corner with a white exclamation mark to basically tell the user that we know this basemap is not valid?
Like this (but not cut off):
The text was updated successfully, but these errors were encountered: