Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error icon for Basemaps that we know will not work. #54

Closed
rolson opened this issue May 4, 2022 · 10 comments
Closed

Show error icon for Basemaps that we know will not work. #54

rolson opened this issue May 4, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@rolson
Copy link
Contributor

rolson commented May 4, 2022

I'm liking the Basemaps gallery. I have an idea for an enhancement that I think would be nice.

When you select a basemap for the first time, it does some loading, and it might determine that the basemap is not valid:

image

That's great.

After that, however, can we add a little red circle in the corner with a white exclamation mark to basically tell the user that we know this basemap is not valid?

Like this (but not cut off):

image

@rolson rolson added the enhancement New feature or request label May 4, 2022
@rolson
Copy link
Contributor Author

rolson commented May 4, 2022

I have a branch that does that here. It needs to be fixed so the icon isn't cut off.

@mhdostal
Copy link
Member

mhdostal commented May 4, 2022

I like this idea as well. The thumbnail fills the space it's given, so there are three ways to get it to work:

1.) Move the icon inside the bounds of the thumbnail
image

2.) Shrink the thumbnail if there's an error to provide room for the icon
image

3.) Always shrink the thumbnails so they are all consistent, whether there's an error or not
image

Thoughts?

@mhdostal
Copy link
Member

mhdostal commented May 4, 2022

cc: @dfeinzimer

@yo1995
Copy link
Contributor

yo1995 commented May 4, 2022

I like 1. Another idea: what about putting the exclamation mark at the center of the thumbnail? Did a quick look up in HIG but didn't find anything related.

@rolson
Copy link
Contributor Author

rolson commented May 4, 2022

I was drawing inspiration from this:

image

I like option 1 or 3. Maybe option 3 a bit more. Maybe option 3 but reduce the space a bit between the thumbnails. Also did we consider rounding the thumbnail corners?

@dfeinzimer
Copy link
Collaborator

At first I liked option 2 better because I felt the larger tiles preserved more details in the previews but now I think the consistent sizing in option 3 looks better.

I might be misremembering but didn't we remove the red we had before in PR 39 because Eric suggested it may be too distracting?
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-05-04 at 15 30 52

@rolson
Copy link
Contributor Author

rolson commented May 5, 2022

That's right, we did have something similar. Sorry, I forgot about that. I do think the right sizing of this element is important if we choose to go with it. I think smaller and we can get an idea by how iOS uses it. Looking how it is used in the iOS home screen, the size the icon takes up is not part of the size of the button. It is eating into the space between the buttons. That's important for getting the spacing and sizing right.

exclamation

@mhdostal
Copy link
Member

mhdostal commented May 5, 2022

How about this? I can't get the exclamation mark to move up and to the right of the thumbnail without making the thumbnail smaller, as the icon is right at the top/trailing edge of the list. Any higher and it gets clipped.

And rounded rects.

image

@rolson
Copy link
Contributor Author

rolson commented May 5, 2022

I like it

@rolson
Copy link
Contributor Author

rolson commented May 5, 2022

We have a a few Basemaps hard-coded that we know will fail. The user should rarely see this in practice as most maps are WM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants