Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: Action icon scale should be medium unless Action scale is L #1020

Closed
asangma opened this issue Jun 23, 2020 · 3 comments
Closed

Bug: Action icon scale should be medium unless Action scale is L #1020

asangma opened this issue Jun 23, 2020 · 3 comments
Assignees
@kat10140
Labels
4 - verified bug Something isn't working
Milestone
Ocean Princess

Comments

@asangma
Copy link
Contributor

asangma commented Jun 23, 2020

Summary

Update icon scale in Action to be better.

Actual Behavior

Icon scale is s unless Action scale is l. Then it is m

Expected Behavior

Icon scale should be m unless Action scale is l. Then it should be l.

Reproduction Steps

  1. Use the icon slot in Action.

Relevant Info

@asangma asangma added bug Something isn't working 1 - assigned labels Jun 23, 2020
@asangma asangma added this to the Ocean Princess milestone Jun 23, 2020
@asangma asangma self-assigned this Jun 23, 2020
asangma added a commit that referenced this issue Jun 23, 2020
@asangma
Updated Action icon scale logic. Cleaned up demo app. (#1020)
49d9d96
@asangma asangma mentioned this issue Jun 23, 2020
Merged
@asangma asangma assigned kat10140 and unassigned asangma Jun 23, 2020
@asangma
Copy link
Contributor Author

asangma commented Jul 22, 2020

Sorry...I meant to add a table that made this more clear.

Intended result is

Action scale Icon scale
L M
M S
S S

@kat10140
Copy link
Contributor

lewks gewd

@asangma
Copy link
Contributor Author

asangma commented Jul 22, 2020

Yew!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified bug Something isn't working
Projects
None yet
Milestone
Ocean Princess
Development

No branches or pull requests
2 participants
@asangma @kat10140