Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the escapeDisabled property on modal and sheet in favor of prevented events #9101

Open
1 of 5 tasks
driskull opened this issue Apr 9, 2024 · 0 comments
Open
1 of 5 tasks

Deprecate the escapeDisabled property on modal and sheet in favor of prevented events #9101

driskull opened this issue Apr 9, 2024 · 0 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@driskull
Copy link
Member

driskull commented Apr 9, 2024

Description

Deprecate the escapeDisabled property on modal and sheet in favor of prevented events

Proposed Advantages

Favor event cancelation for consistency across components.

Which Component

modal
sheet

Relevant Info

Engineering discussions recap on this: we'll track down use case that introduced the prop and consider deprecating and removing in favor of event cancelation.

Original PR: #128

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 9, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@driskull