Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace autoClosableRetainsCloseButton alert screenshot test with e2e #9122

Open
5 tasks
Elijbet opened this issue Apr 12, 2024 · 0 comments
Open
5 tasks

Replace autoClosableRetainsCloseButton alert screenshot test with e2e #9122

Elijbet opened this issue Apr 12, 2024 · 0 comments
Labels
0 - new New issues that need assignment. c-alert Issues that pertain to the calcite-alert component needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Apr 12, 2024

Description

Dropped autoClosableRetainsCloseButton_TestOnly to be replaced with an e2e test asserting close button is retained throughout the length of close delay and closes when prompted.

Proposed Advantages

e2e test is more appropriate for this functionality

Which Component

alert

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 12, 2024
@macandcheese macandcheese added the c-alert Issues that pertain to the calcite-alert component label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. c-alert Issues that pertain to the calcite-alert component needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macandcheese @Elijbet