Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calcite-button - setting disabled: false on a button after its creation causes other (unrelated) disabled buttons to again respond to click events in Firefox #9565

Open
2 of 6 tasks
iyouth23 opened this issue Jun 12, 2024 · 2 comments
Assignees
Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. ArcGIS Online Issues logged by ArcGIS Online team members. browser-firefox Issues tied to the last 2 versions of Firefox browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@iyouth23
Copy link

iyouth23 commented Jun 12, 2024

Check existing issues

Actual Behavior

When multiple calcite-buttons lie at the same DOM level, setting disabled = false programmatically to one button causes all other neighboring calcite-buttons, regardless of their own disabled setting, to start responding to onClick() events again.

This issue is in a similar vein to #8729. It only occurs in Firefox.

Expected Behavior

Setting one calcite-button's disabled attribute should not affect other, unrelated buttons' event responses.

Reproduction Sample

https://codepen.io/iyouth66/pen/ZENXMNx?editors=1000

Reproduction Steps

  1. Open the provided codepen in Firefox.
  2. Open DevTools.
  3. Click the "Test 3" button to reenable the "Test 2" button.
  4. Now click the "Test 1" button. Even though it is disabled, see that it responds to the onClick() event and prints a message in the console.
  5. Uncomment the div tags where necessary. Observe that the problem no longer occurs.

Reproduction Version

2.9.0

Relevant Info

Not a regression.

cc @geospatialem

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

AGOL Map Viewer has buttons that lie at the same DOM level that are enabled/disabled programmatically. These buttons encounter this issue.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@iyouth23 iyouth23 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jun 12, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 12, 2024
@geospatialem geospatialem added the has workaround Issues have a workaround available in the meantime. label Jun 13, 2024
@kstinson14
Copy link
Contributor

Also running into this issue in Field Maps.

@geospatialem geospatialem added browser-firefox Issues tied to the last 2 versions of Firefox browser. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Jun 25, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jun 25, 2024
@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jun 25, 2024
@jcfranco jcfranco self-assigned this Jun 28, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 28, 2024
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 28, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jun 28, 2024
Copy link
Contributor

Installed and assigned for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. ArcGIS Online Issues logged by ArcGIS Online team members. browser-firefox Issues tied to the last 2 versions of Firefox browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

5 participants