Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calcite Alert "title" slot not appearing correctly when "icon" set to true (or boolean) #9567

Closed
2 of 6 tasks
abp6318 opened this issue Jun 12, 2024 · 4 comments
Closed
2 of 6 tasks
Assignees
Labels
0 - new New issues that need assignment. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive need more info Issues that are missing information and/or a clear, actionable description.

Comments

@abp6318
Copy link
Contributor

abp6318 commented Jun 12, 2024

Check existing issues

Actual Behavior

When setting a calcite-alert's icon attribute to true, the "title" slot does not appear causing the alert to appear empty.

Stopped working when we upgraded from v1.10.0 to v1.11.0 (calcite components).

485d9cf1-0a0b-415a-86b6-8925c9a31617

1 10 --  1 11 Above, the left is 1.10 and the right is 1.11. We changed no code and this is where we see the issue.

There are no listed changes to the calcite-alert in the changelog, but you can see changes in the diff files: @esri/calcite-components@1.10.0...@esri/calcite-components@1.11.0

Expected Behavior

When setting a calcite-alert's icon attribute to true, the "title" slot appears and the icon is determined based on the kind.

Reproduction Sample

https://codepen.io/AaronPutterman/pen/Exzbjqx?editors=1000 // does not seem to happen in codepen

Reproduction Steps

  1. Create a calcite-alert
  2. Set a string in the "title" slot
  3. Set the icon attribute to true
  4. View the difference between v1.10 and v1.11

Reproduction Version

1.11

Relevant Info

  • Chip: Apple M2 Pro,
  • macOS: 14.5 (23F79)
  • MacBook Pro 16-inch, 2023
  • Chrome

Regression?

1.10

Priority impact

impact - p3 - not time sensitive

Impact

We found a minor work around, and this is a very old issue/bug, so I'm guessing this won't get touched for a long time.

Logging in case this issue shows up here or elsewhere in the future.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Hub

@abp6318 abp6318 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jun 12, 2024
@github-actions github-actions bot added ArcGIS Hub Issues logged by ArcGIS Hub team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 12, 2024
@geospatialem geospatialem added spike Issues that cannot be estimated well enough until the team has done further research and removed needs triage Planning workflow - pending design/dev review. labels Jun 25, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jun 25, 2024
@jcfranco
Copy link
Member

jcfranco commented Jun 26, 2024

@abp6318 Thanks for reporting this. A few questions:

  1. Are you using the dist or components output target?
  2. Are components being used in an application framework?
  3. Is this still reproducible in the latest version (2.10.0 releasing soon)?
  4. Could you provide a repro case that demonstrates the issue?

@jcfranco jcfranco added the need more info Issues that are missing information and/or a clear, actionable description. label Jun 26, 2024
@jcfranco
Copy link
Member

when "icon" set to true (or boolean)

Based on the above, there might be some overlap with #9562.

@abp6318
Copy link
Contributor Author

abp6318 commented Jun 27, 2024

@jcfranco --

Are you using the dist or components output target?

I believe we are using the dist, but I can double check and get back to you.

Are components being used in an application framework?

We are using the calcite components within Stencil (web components) and then rendering them with React (in this instance, otherwise we usually use Ember)

Is this still reproducible in the latest version (2.10.0 releasing soon)?

I was unable to repro in the latest version, but my team still thought it was worth logging just in case there's more happening behind the scenes.

Could you provide a repro case that demonstrates the issue? ... Based on the above, there might be some overlap with #9562.

Unforuntately, I can't reproduce this bug in a shareable example, but you're right in that it does appear related to 9562.

@jcfranco
Copy link
Member

@abp6318 Thanks for the info! It seems like using the latest mitigates this issue, so we'll proceed to close.

@jcfranco jcfranco removed the spike Issues that cannot be estimated well enough until the team has done further research label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive need more info Issues that are missing information and/or a clear, actionable description.
Projects
None yet
Development

No branches or pull requests

3 participants