Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list: add matchFields property to specify which fields should be filtered against #9619

Closed
2 of 6 tasks
driskull opened this issue Jun 17, 2024 · 2 comments
Closed
2 of 6 tasks
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone

Comments

@driskull
Copy link
Member

Check existing issues

Description

Add a matchFields property to specify which properties on list to use as matching values.

Acceptance Criteria

new property matchFields

Relevant Info

#5063

Which Component

list

Example Use Case

const list = document.querySelector("calcite-list");
list.matchFields = ["label", "description"];

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 17, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 17, 2024
@driskull driskull self-assigned this Jun 20, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 20, 2024
@driskull driskull added this to the 2024-06-25 - Jun Release milestone Jun 20, 2024
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 21, 2024
Copy link
Contributor

Installed and assigned for verification.

driskull added a commit that referenced this issue Jun 21, 2024
…ilter against (#9622)

**Related Issue:** #9619

## Summary

- add filterProps property to list
- changes `matchFields` to `filterProps` on the filter component.
- add tests
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 24, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.7 with the following:

<!-- HTML -->
<calcite-list filter-enabled filter-placeholder="Filter waypoints">
  <calcite-list-item label="Hiking trails" description="Designated routes for hikers to use." value="hiking-trails">
  </calcite-list-item>
  <calcite-list-item label="Waterfalls" description="Vertical drops from a river." value="waterfalls">
  </calcite-list-item>
  <calcite-list-item label="Rivers" description="Large naturally flowing watercourses." value="rivers">
  </calcite-list-item>
  <calcite-list-item label="Estuaries" description="Where the river meets the sea." value="estuaries">
  </calcite-list-item>
</calcite-list>
// JavaScript
const listEl = document.querySelector("calcite-list")
listEl.filterProps = ["label"];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Development

No branches or pull requests

3 participants