Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Carousel] User can enable autoplay via keyboard when autoplay is not set. #9620

Closed
2 of 6 tasks
macandcheese opened this issue Jun 17, 2024 · 2 comments
Closed
2 of 6 tasks

[Carousel] User can enable autoplay via keyboard when autoplay is not set. #9620

macandcheese opened this issue Jun 17, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-carousel Issues that pertain to the calcite-carousel component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-06-25 - Jun ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jun 17, 2024 •
edited
Loading

Check existing issues

Actual Behavior

Currently, keyboard enter or space interactions will play / pause the Carousel when the component is in focus - even if autoplay is not requested by the developer via property.

Screen.Recording.2024-06-17.at.2.46.08.PM.mov

Expected Behavior

The user should only be able to enable autoplay via keyboard when it is enabled via property.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/xxNpvqq?editors=1000

Reproduction Steps

  1. Open Codepen
  2. Click the onboarding button
  3. The Carousel will focus on Popover open - use the space or enter to begin autoplay.
  4. Notice autoplay has begun - when it should not have.

Reproduction Version

2.9

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 17, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jun 17, 2024
@macandcheese macandcheese added this to the 2024-06-25 - Jun Release milestone Jun 17, 2024
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed Calcite (design) Issues logged by Calcite designers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. labels Jun 17, 2024
@macandcheese macandcheese self-assigned this Jun 17, 2024
@macandcheese macandcheese added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. c-carousel Issues that pertain to the calcite-carousel component and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Jun 17, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jun 17, 2024
@macandcheese macandcheese mentioned this issue Jun 17, 2024
Merged
macandcheese added a commit that referenced this issue Jun 17, 2024
@macandcheese
fix(carousel): Prevent unexpected keyboard autoplay activation (#9621)
f674964 
**Related Issue:** #9620 

## Summary
Adds a check for `autoplay` in our keyboard interaction handler. Adds a
test to confirm behavior.
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned macandcheese Jun 17, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 18, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Jun 18, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-carousel Issues that pertain to the calcite-carousel component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP