Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Pull markers out into separate repo/plugin #14

Closed
kneemer opened this issue Dec 19, 2014 · 5 comments
Closed

Pull markers out into separate repo/plugin #14

kneemer opened this issue Dec 19, 2014 · 5 comments
Milestone

Comments

@kneemer
Copy link
Contributor

kneemer commented Dec 19, 2014

The markers could be reused by anyone wanting to use one of the Esri marker types; Square, Cross, X or Diamond. They should get their own space and pulled into this plugin when building.

@patrickarlt do you have any opinions on naming or structure of the plugin? esri-leaflet-markers, esri-markers?

@kneemer kneemer added this to the leaflet-1.0 milestone Dec 19, 2014
@patrickarlt
Copy link
Contributor

It might sound kinda excessive but I think each one should be a separate library just namespaced under Leaflet.

  • Leaflet.SquareMarker
  • Leaflet.CrossMarker
  • Leaflet.XMarker
  • Leaflet.DiamondMarker

I'm going off https://github.com/jdfergason/Leaflet.Ellipse as an example.

@kneemer
Copy link
Contributor Author

kneemer commented Dec 27, 2014

Sounds good, I noticed that they added a triangle marker in 10.1(?) so I can add that while I'm at it.

@kneemer
Copy link
Contributor Author

kneemer commented Dec 30, 2014

@patrickarlt - I created these in my repo for now with package.json files so that I could get them with npm. I then included them in my build process but it seemed weird to reference them within the node_modules folder. Is there a better way to do this?

@kneemer kneemer closed this as completed Dec 31, 2014
@kneemer kneemer reopened this Dec 31, 2014
@kneemer
Copy link
Contributor Author

kneemer commented Jan 21, 2015

The markers had so much shared code that I put them into one repo with a base class of the shared code and each marker is just responsible for the svg and canvas drawing.

@kneemer
Copy link
Contributor Author

kneemer commented Jan 28, 2015

Done for leaflet-1.0

@kneemer kneemer closed this as completed Jan 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants