Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getScript() a public API? #44

Closed
tomwayson opened this issue Nov 7, 2017 · 1 comment · Fixed by #69
Closed

Make getScript() a public API? #44

tomwayson opened this issue Nov 7, 2017 · 1 comment · Fixed by #69
Labels
enhancement
Milestone
2.0.0

Comments

@tomwayson
Copy link
Member

Why not?

Also, this change has always bothered me a bit. I think isLoaded() should not be concerned with how the script tag was added to the page. Making getScript() a public API would pave the way to revert that change (at the next major release) b/c consumers could just call isLoaded() && getScript() if needed.

cc @TheKeithStewart
@TheKeithStewart
Copy link
Contributor

Makes sense. Sounds good to me, @tomwayson.

@tomwayson tomwayson added this to the 2.0.0 milestone Dec 20, 2017
tomwayson added a commit that referenced this issue Jan 2, 2018
@tomwayson
make getScript() a public API
1f5f165 
resolves #44
@tomwayson tomwayson mentioned this issue Jan 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

make getScript() a public API Esri/esri-loader
2 participants
@tomwayson @TheKeithStewart