Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release artifacts #50

Closed
tomwayson opened this issue Nov 10, 2017 · 1 comment · Fixed by #54
Closed

Release artifacts #50

tomwayson opened this issue Nov 10, 2017 · 1 comment · Fixed by #54

Comments

@tomwayson
Copy link
Member

The release should include an esm build as well as the umd build. Also should make sure the types/interfaces are released in a way that they can be consumed by TypeScript apps/libraries, however that works.

We should update package.json to point to those.
@tomwayson tomwayson mentioned this issue Nov 10, 2017
Closed
@tomwayson
Copy link
Member Author

Oops, apparently there are already entries, but they are invalid:

esri-loader/package.json

Lines 6 to 7 in 28653c0

"module": "src/esri-loader.js",
"types": "src/esri-loader.d.ts",
.

@tomwayson tomwayson mentioned this issue Nov 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

output esm and .d.ts to dist folder, only include dist/src when publishing Esri/esri-loader
1 participant
@tomwayson