Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Military Tools GP tools from Conda package Radial Line of Sight and Linear Line of Sight lack input feature sets #89

Closed
BobBooth opened this issue Dec 17, 2018 · 5 comments

Comments

@BobBooth
Copy link

With the latest build of Military Tools, when I install the GP tools using the Conda install package, two tools in the Visibility toolset lack feature sets for input observer points
Radial Line of Sight
Linear Line of Sight (input observers missing, targets feature set is present)

image
image

RLOS and Range does have feature set.

This was fixed for the toolbox in the repo, I think the Conda package needs to be rebuilt with the latest version of the GP tools.

Expected Behavior

Tools should have input observer points feature sets.

Your Environment

Pro 2.3.0 Beta 2
Military Tools 12/14 build.

@lfunkhouser
Copy link
Member

When rebuild conda package, update to version of MT and python in filename
militarytools-3.3-py36_0.tar

@csmoore
Copy link
Member

csmoore commented Jan 15, 2019

Build created to test at: Solutions\DefenseSolutions\MilitaryToolsForArcGIS\January2019\Dev\182

Note: Conda package version has been updated to 3.3 in this build:
image

@csmoore csmoore self-assigned this Jan 15, 2019
@csmoore csmoore added this to the 2019 JAN Sprint 16 milestone Jan 15, 2019
@BobBooth
Copy link
Author

Tested on Pro 2.2.
Used the MT Analysis toolbar tools first, then installed the conda package and tested and the tools from the conda package.
Found that the tools all had appropriate input feature sets.
It seems to me as though the process of populating the output features box took a long time, and overall performance was generally worse for the tools after the Conda install.

@csmoore
Copy link
Member

csmoore commented Jan 15, 2019

After numerous travails trying to clone the pro conda environment ("error cloning"), I was able to install the latest dev-built Military Tools conda package and successfully test this tool with latest build on Pro 2.2 and 2.3 - input and output symbology show up for this tool.

image

image

image

Also checked version (3.3 - Note: looks like a Pro bug on Pro 2.1, 2.2 that homepage, description and license do not show up, but they do show up+work on Pro 2.3):

Pro 2.3:
image

Pro 2.2:
image

Tested from dev so removing dev and QC labels

@lfunkhouser
Copy link
Member

@csmoore The description not showing up was known at 2.2. The team had hoped to push an update to it, but it wasn't critical, so it was planned to show up in 2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants