New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderOfBattle - very minor - just remove or explain commented out code #14

Closed

csmoore opened this issue Oct 15, 2013 · 3 comments

Assignees

Milestone

Initial Release (...

Member

csmoore commented Oct 15, 2013

Just go through the commented out code in the project and either remove or add some comments to explain why you are keeping

https://github.com/ArcGIS/solutions-widgets-wpf/tree/master/source/OrderOfBattle/OrderOfBattle

Example:

https://github.com/ArcGIS/solutions-widgets-wpf/blob/master/source/OrderOfBattle/OrderOfBattle/OOBCache.cs#L59

ghost assigned pHill5136

Contributor

pHill5136 commented Nov 13, 2013

Removed code comments with issue #17 merge

Member Author

csmoore commented Dec 10, 2013

Looks like just 1 file was missed so keeping open as a reminder:

https://github.com/Esri/solutions-widgets-wpf/blob/master/source/OrderOfBattle/OrderOfBattle/Config/OOBWidgetDialog.xaml.cs#L24

https://github.com/Esri/solutions-widgets-wpf/blob/master/source/OrderOfBattle/OrderOfBattle/Config/OOBWidgetDialog.xaml.cs#L410

ghost assigned pHill5136

Member Author

csmoore commented Dec 17, 2013

I did this when reviewing/resolving #19

csmoore closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment