Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Models #117

Open
hoxirious opened this issue Oct 31, 2021 · 0 comments · May be fixed by #140
Open

Separate Models #117

hoxirious opened this issue Oct 31, 2021 · 0 comments · May be fixed by #140
Assignees
@hoxirious
Labels
documentation Improvements or additions to documentation

Comments

@hoxirious
Copy link
Collaborator

I notice that we use Models for many functionalities like setting up for Firebase, data of different components, and models. I suggest it would be cleaner if we could separate into Services, Data, and Model.

  • Services will have anything related to fetching/requesting data on Firebase, or better we can create a folder named apis and then inside there are Services folder and Utils folde where Services will take care of our service job and Utils will take care of the other helper job for service or any other external job.
  • Data will hold data such as routers, or any kind of static data.
  • Model will take care defining interfaces.
@Dennull Dennull added the documentation Improvements or additions to documentation label Nov 6, 2021
@hoxirious hoxirious self-assigned this Apr 5, 2022
@hoxirious hoxirious linked a pull request Apr 14, 2022 that will close this issue
Ref/hy/model separate #140
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoxirious hoxirious

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ref/hy/model separate ess-uofc/ess-schulichhub
2 participants
@hoxirious @Dennull