Optimize player / user iteration. #733
Conversation
md-5
commented
Jul 12, 2014
md-5
commented
- Add a method for backwards compatability with unmapped code.
- Convert all getOnlinePlayers() calls to use this method, part of the Essential interface
- Add a new method getOnlineUsers() Ljava/lang/Iterable;
- Convert appropriate calls to use this method
- Update Bukkit to #1945
- Update CraftBukkit to #3103
|
@khobbits I missed any additional feedback you may/may not have left on IRC after my changes, if you could copy it / discuss here that would be great. |
* Add a method for backwards compatability with unmapped code. * Convert all getOnlinePlayers() calls to use this method, part of the IEssentials interface * Add a new method getOnlineUsers() Ljava/lang/Iterable; * Convert appropriate calls to use this method * Update Bukkit to #1945 * Update CraftBukkit to #3103
|
The biggest issue with doing something like that is it pollutes the code base with 'temp' hacks. I'm not sure if that is a road we want to continue down, at least not to this extent. |
|
@khobbits the only temp hack' is maintaining support for older Bukkit releases. If you are really opposed to that we can just delete the backwards compatibility and force a version bump. |
|
However that being said the current code is pretty non intrusive, its not like it uses any NMS, rather just calls a method of the API not present at compile time. |
|
I'm just not sure I like that sort of backwards workaround bloat. A little while ago I started adding a few minor things like this to allow some of the more recent versions of Essentials to 'work' with modded servers running against older Bukkit versions, where they would error but not cause the server to stop working. While I managed to fix them, it made me really hesitant to work on new code that I know will break compatibility with older versions. In-fact that reminds me, I can probably remove most of those since the UUID probably broke those. |
|
merged. |
