Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor (cosmetic) - could Loading save analysis messages be suppressed? #138

Closed
aldanor opened this issue Sep 4, 2022 · 2 comments · Fixed by #148
Closed

Minor (cosmetic) - could Loading save analysis messages be suppressed? #138

aldanor opened this issue Sep 4, 2022 · 2 comments · Fixed by #148

Comments

@aldanor
Copy link

aldanor commented Sep 4, 2022

Those are definitely useful as verbose/debug info but most of the time, why would the user care? Could they be hidden behind a verbose flag or even easier, and env var? (e.g. CARGO_UDEPS_VERBOSE)

Asking because the typical use case is...

$ cargo +nightly udeps

<2 pages of 'info: Loading save analysis from ...'>
All deps seem to have been used.

(apologies in advance if I'm missing something obvious here)

@est31
Copy link
Owner

est31 commented Sep 4, 2022

Hmm yeah I'm open to adding an option for it, opt-in even. Maybe we should control this via rust logging levels?

@aldanor
Copy link
Author

aldanor commented Sep 18, 2022

Hmm yeah I'm open to adding an option for it, opt-in even. Maybe we should control this via rust logging levels?

Opt-in with rust log levels sounds great. (Because that's what it looks like anyway - a debug/trace-level internal log).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants