Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dryRun and --dry-run does not seem to work as expected #129

Open
haghabozorgi opened this issue Jan 28, 2022 · 2 comments
Open

dryRun and --dry-run does not seem to work as expected #129

haghabozorgi opened this issue Jan 28, 2022 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@haghabozorgi
Copy link
Contributor

We are testing the image swapper and have deployed it to our eks cluster, and the dryRun flag does not seem to be working (the actions are still taken; repo is created, image is uploaded, image ref is updated).

When we set the helm chart with

config:
  dryRun: true
  logLevel: debug
  logFormat: console

and/or set --dry-run=true as arg in deployment spec the actions are still executed.

@estahn
Copy link
Owner

estahn commented Sep 7, 2022

@haghabozorgi Are you still having this issue? Can you export the k8s-image-swapper configmap and add it?

@estahn estahn self-assigned this Sep 7, 2022
@estahn estahn added the question Further information is requested label Sep 7, 2022
@mimmus
Copy link

mimmus commented Oct 26, 2022

Yes, I can confirm: --dry-run is ineffective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants