Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pafrecord from_str with rust-csv deserialize [#8] #11

Merged
merged 1 commit into from Mar 19, 2022

Conversation

esteinig
Copy link
Owner

  • tiny degradation in parsing speed on large test file, speedup on small test file
  • in favor of safer record parsing using rust-csv and serde deserialization
  • simplifies PafRecord custom string parsing
  • full test coverage

@esteinig
Copy link
Owner Author

Codecov Report

Merging #11 (b822aba) into main (13c2843) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          154       142   -12     
=========================================
- Hits           154       142   -12     
Impacted Files Coverage Δ
src/cli.rs 100.00% <ø> (ø)
src/covplot.rs 100.00% <ø> (ø)
src/paf.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c2843...b822aba. Read the comment docs.

@esteinig esteinig merged commit 5014d0f into main Mar 19, 2022
@esteinig esteinig deleted the csv_reader branch March 19, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant