Highlight doesn't reset style for trace/trace color is unreadable

[judemille]

#167 added a color for trace, but didn't add a match arm to reset the style. This results in all text after a highlighted trace being black. Also of note is that in a dark terminal, the trace highlight is unreadable. I would suggest putting no coloring on it at all if it's going to be black or white.

[estk]

@IceSentry any idea about this?

[IceSentry]

@judemille do you highlight the entire line when logging?

The PR was meant to use the same color as env_logger because the original weren't distinctive enough (red for ERROR and WARN), which look fine in a dark themed terminal if it's not the entire line that's being highlighted. I think the best fix for this would be to just make it configurable. As a temporary fix you might want to not highlight the entire line, but I think it makes sense even for trace to have a specific highlight color, but the default could easily be different or None.

This is how it looks for me with env_logger in a dark themed terminal. And this is also how it looked for me with my PR.

[judemille]

My config is "{h({l})} {d} {t} {M} - {m} {n}"

[IceSentry]

I'm not sure just removing the color is a fix here. I understand my original PR didn't take into account highlighting the entire line or a very dark theme in general, but it would be better to have a way to change the color. I agree the lack of a reset was my mistake though.

[judemille]

I'm not sure there's a better way to go about it easily.

[IceSentry]

Yeah, I don't think there's an easy way to add configuration. I think your PR is probably good enough for now. I was just really annoyed by ERROR and WARN having different shades of red which is why I made the original PR, but TRACE is fine with default colors

[estk]

@IceSentry, if this works for you will you approve the pr? Ill check locally tomorrow.

…

On Oct 3, 2020, 20:44 -0700, Charles Giguere ***@***.***>, wrote: Yeah, I don't think there's an easy way to add configuration. I think your PR is probably good enough for now. I was just really annoyed by ERROR and WARN having different shades of red, but TRACE is fine with default colors — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[IceSentry]

@estk I added a comment of something that could be changed, but the PR works for me so I approved it.

[estk]

This has been addressed in #186